8000 fix: mutator not resizing for flyout by BeksOmega · Pull Request #6917 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: mutator not resizing for flyout #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: mutator not resizing for flyout #6917

merged 1 commit into from
Mar 28, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #4086

Proposed Changes

Adds a listener to the flyout so that changes to the flyout resize the workspace as well.

Reason for Changes

Fixin buggies.

Test Coverage

Manual testing with google/blockly-samples#1638

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner March 22, 2023 20:12
@BeksOmega BeksOmega requested a review from maribethb March 22, 2023 20:12
@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 22, 2023
@BeksOmega BeksOmega merged commit 7291fa0 into google:develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribethb maribethb maribethb approved these changes

Assignees

@maribethb maribethb

Labels
PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutator bubble gets misconfigured if sub-block gets wider
2 participants
@BeksOmega @maribethb
0