fix: Fix scrolling of menus on mobile. #6911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Just checking for my own understanding-
when you scroll, it doesn't select the item you're hovering over when you stop scrolling and lift your finger, right? and that works because the browser is smart enough to issue a pointercancel event once the element is scrolled? I couldn't find Blockly-specific code that's cancelling it but after a quick review of the pointer events spec that's what I think is happening, and wanted to confirm that's your understanding as well.
|
Correct, experimentally it behaves as you describe/would expect - the item you let up on isn't selected, you have to tap (separate from initiating/ending the scroll) to select one. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6759
Proposed Changes
The menu item selection handler is triggered on pointerup vs down.
Behavior Before Change
Attempting to scroll a menu on mobile would select the item that was tapped to initiate the scroll.
Behavior After Change
Menus can be scrolled as expected, and tapping an item selects it.