8000 fix(tests): Use `build/msg/en.js` instead of `msg/messages.js` by cpcallen · Pull Request #6825 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(tests): Use build/msg/en.js instead of msg/messages.js #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix(tests): Use build/msg/en.js instead of msg/messages.js #6825

merged 1 commit into from
Feb 7, 2023

Conversation

cpcallen
Copy link
Contributor
@cpcallen cpcallen commented Feb 6, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6824.

Proposed Changes

Use en.js instead of messages.js in tests.

Reason for Changes

messages.js is not intended to be used this way. Also: we want to test build output.

Additional Information

This change had already been made (by PR #6475 amongst other) to most of the tests, but there were a couple of stragglers that still mentioned messages.js.

@cpcallen
fix(tests): Use build/msg/en.js instead of msg/messages.js
6d5410b 
This change had already been made (by PR google#6475 amongst other) to
most of the tests, but there were a couple of stragglers that
still mentioned messages.js.

Fixes google#6824.
@cpcallen cpcallen marked this pull request as ready for review February 6, 2023 17:43
@cpcallen cpcallen requested a review from a team as a code owner February 6, 2023 17:43
@cpcallen cpcallen requested a review from maribethb February 6, 2023 17:43
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Feb 6, 2023
@cpcallen cpcallen merged commit d808c06 into google:develop Feb 7, 2023
@cpcallen cpcallen deleted the fix/6824-en.js-not-messages.js branch February 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribethb maribethb maribethb approved these changes

Assignees

@maribethb maribethb

Labels
component: tests PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify tests to load build/msg/en.js instead of msg/messages.js
2 participants
@cpcallen @maribethb
0