fix(tests): Have npm start run a full build
#6770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing npm start in a clean checkout loads a broken playground, because the deps script does not run buildLangfiles. To fix this (and also to ensure that compressed playground loading also works, even though uncompressed is the default), have the start script run the build script rather than just deps.
npm start run a full build
BeksOmega
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Doing
npm startin a clean checkout loads a broken playground, because thedepsscript does not runbuildLangfiles.Proposed Changes
To fix this have the
startscript run thebuildscript rather than justdeps. This also ensures that compressed playground loading would work too (though uncompressed is the default).