8000 fix: undoing pasting procedure callers that create defs by BeksOmega · Pull Request #6750 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: undoing pasting procedure callers that create defs #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2023
Merged

fix: undoing pasting procedure callers that create defs #6750

merged 2 commits into from
Jan 12, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Records undo events for creating a new def to be associated with a deserialized (e.g. pasted) caller so that the events can be grouped with the creation of the caller.

Reason for Changes

before undoing creating a caller that created its associated definition would not also delete the definition. Now it does (maintaining the behavior on master).

Test Coverage

Manual testing.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner January 10, 2023 18:33
@BeksOmega BeksOmega requested a review from NeilFraser January 10, 2023 18:33
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 10, 2023
cpcallen
cpcallen reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor
@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving createDef_ in the same commit as it is modified makes it very hard to see what changed.

It appears that you've just added a {recordUndo: true}—is that correct?

Why move it?

@BeksOmega BeksOmega force-pushed the fix/procedure-caller-paste-undo branch from 5cbbefc to affe73e Compare January 11, 2023 18:25
@BeksOmega
Copy link
Collaborator Author

Split into two commits, second commit has an explanation for why it moved =)

@BeksOmega BeksOmega merged commit 9f73184 into google:develop Jan 12, 2023
@BeksOmega BeksOmega deleted the fix/procedure-caller-paste-undo branch May 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcallen cpcallen cpcallen approved these changes

@NeilFraser NeilFraser Awaiting requested review from NeilFraser NeilFraser is a code owner automatically assigned from google/blockly-eng

Assignees

@NeilFraser NeilFraser

Labels
PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BeksOmega @cpcallen @NeilFraser
31A9
0