chore: remove underscores from some private properties and methods #6537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
General cleanup/matching style guide
Proposed Changes
Remove underscores from some private properties and methods. Update tests where needed to use public APIs instead of private properties.
Behavior Before Change
No change.
Behavior After Change
No change.
Reason for Changes
Match style guide (no underscores in private properties) and stop using private properties in tests.
Test Coverage
Mocha tests.
Documentation
Additional Information
I didn't get every case in workspace svg, because some are used in unexpected ways. These are just the trivial ones.