8000 feat: trigger updates to IProcedureBlock blocks by BeksOmega · Pull Request #6570 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: trigger updates to IProcedureBlock blocks #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 25, 2022
Merged

feat: trigger updates to IProcedureBlock blocks #6570

merged 5 commits into from
Oct 25, 2022

Conversation

BeksOmega
Copy link
Collaborator
@BeksOmega BeksOmega commented Oct 19, 2022 •
edited
Loading

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#6515

Proposed Changes

Makes it so updates to the procedure data models actually trigger updates to blocks.

Note that the built-in blocks haven't be refactored to /respond/ to these updates. But now they could be.

Test Coverage

Enabled skipped tests!

Documentation

N/A

Additional Information

Dependent on #6569

@BeksOmega BeksOmega requested a review from a team as a code owner October 19, 2022 17:51
@BeksOmega BeksOmega requested a review from NeilFraser October 19, 2022 17:51
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Oct 19, 2022
This was referenced Oct 20, 2022
Merged
Merged
@BeksOmega BeksOmega force-pushed the feat/trigger-procedure-updates branch from af7d30d to 6651814 Compare October 25, 2022 15:53
@BeksOmega BeksOmega merged commit c9ced48 into google:develop Oct 25, 2022
@release-please release-please bot mentioned this pull request Oct 25, 2022
Closed
@BeksOmega BeksOmega mentioned this pull request Oct 25, 2022
Closed
@BeksOmega BeksOmega deleted the feat/trigger-procedure-updates branch May 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeilFraser NeilFraser NeilFraser approved these changes

Assignees

@NeilFraser NeilFraser

Labels
PR: feature Adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeksOmega @NeilFraser
0