8000 Add a `blocklyTrashcanFlyout` CSS class to the flyout if it is used by the trashcan · Issue #8342 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a blocklyTrashcanFlyout CSS class to the flyout if it is used by the trashcan #8342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BeksOmega opened this issue Jul 12, 2024 · 5 comments
Closed

Add a blocklyTrashcanFlyout CSS class to the flyout if it is used by the trashcan #8342

BeksOmega opened this issue Jul 12, 2024 · 5 comments
Assignees
@ChaitanyaYeole02
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

In the trashcan's init method, before inserting the result of this.flyout!.createDom into the DOM, call dom.addClass with the result of this.flyout!.createDom and blocklyTrashcanFlyout.

This change should be made against the rc/v12.0.0 branch.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added good first issue labels Jul 12, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 12, 2024
@BeksOmega BeksOmega mentioned this issue Jul 15, 2024
Closed
@ChaitanyaYeole02
Copy link
Contributor

Hey. Can you assign the issue to me please, as discussed?

@BeksOmega
Copy link
Collaborator Author

Done! Let me know if you have an questions @ChaitanyaYeole02 =)

ChaitanyaYeole02 added a commit to ChaitanyaYeole02/blockly that referenced this issue Jul 15, 2024
@ChaitanyaYeole02
feature/google#8342 Added blocklyTrashcanFlyout CSS class to the flyout
a418c17
@ChaitanyaYeole02 ChaitanyaYeole02 mentioned this issue Jul 15, 2024
Merged
1 task
@siddharthbaleja7
Copy link

Hey.Can you please assign this issue to me?

@BeksOmega
Copy link
Collaborator Author

Sorry @siddharthbaleja7 This is already being worked on :/

@BeksOmega
Copy link
Collaborator Author

Closed by #8372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChaitanyaYeole02 ChaitanyaYeole02

Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
v12
Development

No branches or pull requests
3 participants
@BeksOmega @ChaitanyaYeole02 @siddharthbaleja7
0