10000 Add a `blocklyTextBubble` CSS class to the text bubble · Issue #8331 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a blocklyTextBubble CSS class to the text bubble #8331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BeksOmega opened this issue Jul 11, 2024 · 4 comments
Closed

Add a blocklyTextBubble CSS class to the text bubble #8331

BeksOmega opened this issue Jul 11, 2024 · 4 comments
Assignees
@Nirmalkumar6112
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator
BeksOmega commented Jul 11, 2024 •
edited
Loading

In the text bubble constructor, add a call to dom.addClass that adds a blocklyTextBubble CSS class to the this.svgRoot.

This change should be made against the rc/v12.0.0 branch.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added good first issue labels Jul 11, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 11, 2024
@Nirmalkumar6112
Copy link
Contributor

Hey @BeksOmega, I would like to work on this.

Nirmalkumar6112 added a commit to Nirmalkumar6112/blockly that referenced this issue Jul 12, 2024
@Nirmalkumar6112
fix: Add a blocklyTextBubble CSS class to the text bubble google#8331
2603b07
@Nirmalkumar6112 Nirmalkumar6112 mentioned this issue Jul 12, 2024
Merged
1 task
@BeksOmega
Copy link
Collaborator Author

@Nirmalkumar6112 sweetness :D Thanks for commenting! I've assigned you, and I'll take a look at your PR.

Nirmalkumar6112 added a commit to Nirmalkumar6112/blockly that referenced this issue Jul 12, 2024
@Nirmalkumar6112
fix: Add a blocklyTextBubble CSS class to the text bubble google#8331
8657157
@siddharthbaleja7
Copy link

@Nirmalkumar6112 Please assign this issue to me.

BeksOmega pushed a commit that referenced this issue Jul 16, 2024
@Nirmalkumar6112
feat: Add a blocklyTextBubble CSS class to the text bubble #8331 (#8333)
c553206
@BeksOmega
Copy link
Collaborator Author

Closed by #8333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nirmalkumar6112 Nirmalkumar6112

Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
v12
Development

No branches or pull requests
3 participants
@BeksOmega @Nirmalkumar6112 @siddharthbaleja7
0