8000 Stack wiggle is gone or much reduced · Issue #8194 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stack wiggle is gone or much reduced #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
NeilFraser opened this issue Jun 5, 2024 · 4 comments · Fixed by #8743
Closed
1 task

Stack wiggle is gone or much reduced #8194

NeilFraser opened this issue Jun 5, 2024 · 4 comments · Fixed by #8743
Assignees
@SantoshPisini
Labels
cla: yes Used by Google's CLA checker. help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days type: regression
Milestone
Upcoming

Comments

@NeilFraser
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

When disconnecting a stack of blocks, the stack should wiggle. This used to be clearly visible, as demonstrated here:
https://blockly.games/turtle?lang=en&level=10#qttj9u

However the current published version of Blockly either doesn't have a wiggle at all, or else the wiggle is tiny. This inconsistency smells like a race condition.

Reproduction steps

  1. Go to https://blockly-demo.appspot.com/static/demos/code/index.html#u8h4fw
  2. Pull the first 'if' statement out of the loop.

Stack trace

No response

Screenshots

No response

Browsers

Chrome desktop, Firefox desktop
@NeilFraser NeilFraser added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Jun 5, 2024
@cpcallen cpcallen added help wanted External contributions actively solicited cla: yes Used by Google's CLA checker. good first issue and removed issue: triage Issues awaiting triage by a Blockly team member labels Jun 14, 2024
@cpcallen cpcallen added this to the Upcoming milestone Jun 14, 2024
@SantoshPisini
Copy link

Hello, I would like to give this issue a try!

@BeksOmega
Copy link
Collaborator

@SantoshPisini go for it! Let me know if you have any questions =)

@SantoshPisini
Copy link

@BeksOmega I'm unable to repro this issue locally(at /tests/playground.html). If there anything that I need to do to repo this?

@BeksOmega
Copy link
Collaborator

Hmm in my testing it seems to be inconsistent, sometimes the wiggliness is the same as on https://blockly.games/turtle?lang=en&level=10#qttj9u and sometimes it's much reduced. So I don't have any additional repo steps for you, but the inconsistency may mean there's a race condition making it hard for you to repro.

@BeksOmega BeksOmega added size: small Bugs that can be picked up and completed in 1-3 days and removed good first issue labels Aug 13, 2024
RoboErikG added a commit to RoboErikG/blockly that referenced this issue Jan 17, 2025
@RoboErikG
fix: Make the wiggle consistent (google#8194)
a4e06a7 
On busier pages or slower machines the wiggle is sometimes lost due to skipped frames and
a high chance of the skew calculation rounding to 0. This changes to using a counter
for the skew which provides a more consistent animation. Also sets the timeout
to 15ms instead of 10 to avoid double updates since 60fps is ~16 ms.
RoboErikG added a commit to RoboErikG/blockly that referenced this issue Jan 17, 2025
@RoboErikG
fix: Make the wiggle consistent (google#8194)
6d6c322 
On busier pages or slower machines the wiggle is sometimes lost due to skipped frames and
a high chance of the skew calculation rounding to 0. This changes to using a counter
for the skew which provides a more consistent animation. Also sets the timeout
to 15ms instead of 10 to avoid double updates since 60fps is ~16 ms.
RoboErikG added a commit to RoboErikG/blockly that referenced this issue Jan 21, 2025
@RoboErikG
Fix google#8194 by using animation steps for the wiggle
7ffbab3
@RoboErikG RoboErikG mentioned this issue Jan 21, 2025
Merged
1 task
RoboErikG added a commit to RoboErikG/blockly that referenced this issue Feb 19, 2025
@RoboErikG
Fix: google#8194 by using a stepped animation for the wiggle (google#…
ec00adf 
…8743)

* Fix google#8194 by using animation steps for the wiggle

* Formatting cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SantoshPisini SantoshPisini

Labels
cla: yes Used by Google's CLA checker. help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days type: regression
Projects
None yet
Milestone
Upcoming
Development

Successfully merging a pull request may close this issue.

Fix: #8194 by using a stepped animation for the wiggle RoboErikG/blockly
4 participants
@NeilFraser @cpcallen @BeksOmega @SantoshPisini
0