8000 python: Assert that libdir is a Path in all branches by nicholasjng · Pull Request #1992 · google/benchmark · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

python: Assert that libdir is a Path in all branches #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

python: Assert that libdir is a Path in all branches #1992

wants to merge 1 commit into from

Conversation

nicholasjng
Copy link
Contributor

The inplace=True branch previously relied on some non-triv 84BF ial interactions between str and pathlib.Path objects, which produces unexpected values in cases of s / p, where s is a string and p is an absolute path.

To fix, just create a pathlib.Path of the return value of build_py.get_package_dir().

@nicholasjng
python: Assert that libdir is a Path in all branches
b08be36 
The `inplace=True` branch previously relied on some non-trivial interactions
between `str` and `pathlib.Path` objects, which produces unexpected values in
cases of `s / p`, where `s` is a string and `p` is an absolute path.

To fix, just create a `pathlib.Path` of the return value of `build_py.get_package_dir()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicholasjng
0