8000 Add missing trailing commas by dmah42 · Pull Request #1182 · google/benchmark · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing trailing commas #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2021
Merged

Add missing trailing commas #1182

merged 2 commits into from
Jun 18, 2021

Conversation

dmah42
Copy link
Member
@dmah42 dmah42 commented Jun 18, 2021

Fixes #1181

@google-cla google-cla bot added the cla: yes label Jun 18, 2021
miki-shapr
miki-shapr reviewed Jun 18, 2021
View reviewed changes
miki-shapr
miki-shapr reviewed Jun 18, 2021
View reviewed changes
miki-shapr
miki-shapr suggested changes Jun 18, 2021
View reviewed changes
Copy link
@miki-shapr miki-shapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only append a comma at the end of a line if it is followed by another entry.

@dmah42
Copy link
Member Author
dmah42 commented Jun 18, 2021

Only append a comma at the end of a line if it is followed by another entry.

i think i got it. can you approve if you think so @miki-shapr ?

miki-shapr
miki-shapr approved these changes Jun 18, 2021
View reviewed changes
Copy link
@miki-shapr miki-shapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dmah42 dmah42 merged commit 62937f9 into main Jun 18, 2021
@dmah42 dmah42 deleted the 1181 branch June 18, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miki-shapr miki-shapr miki-shapr approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Custom context with JSON file reporter produces invalid JSON
2 participants
@dmah42 @miki-shapr
0