8000 Avoid breakages for builds with libprotobuf < 3.16.0 by dhoekwater · Pull Request #197 · google/autofdo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid breakages for builds with libprotobuf < 3.16.0 #197

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

Avoid breakages for builds with libprotobuf < 3.16.0 #197

merged 1 commit into from
Jul 1, 2024

Conversation

dhoekwater
Copy link
Collaborator

Recent commit 623c777 upgraded perf_data_converter to a version that
uses google::protobuf::RepeatedField<unsigned int>::Assign, which was
introduced in libprotobuf version 3.16.0. This commit breaks builds
that use libprotobuf < 3.16.0, such as stock builds on Ubuntu 20.04
(which uses v3.6.1) and Ubuntu 22.04 (which uses v3.12.4).

Thankfully, this dependency was introduced after the SPE Decoder, so we
can take a snapshot of perf_data_converter in the compatible range.

@dhoekwater
Avoid breakages for builds with libprotobuf < 3.16.0
ebe6a48 
Recent commit 623c777 upgraded perf_data_converter to a version that
uses `google::protobuf::RepeatedField<unsigned int>::Assign`, which was
introduced in libprotobuf version 3.16.0. This commit breaks builds
that use libprotobuf < 3.16.0, such as stock builds on Ubuntu 20.04
(which uses v3.6.1) and Ubuntu 22.04 (which uses v3.12.4).

Thankfully, this dependency was introduced after the SPE Decoder, so we
can take a snapshot of perf_data_converter in the compatible range.
@dhoekwater
Copy link
Collaborator Author

All checks passing on Debian 6.6.15

$ cmake -G Ninja -DWITH_LLVM=On -DCMAKE_BUILD_TYPE=Release -S . -B build
$ ninja -C build && ninja -C build test

100% tests passed, 0 tests failed out of 23

Total Test time (real) =   8.58 sec

Fixes #193

@snehasish snehasish self-requested a review July 1, 2024 20:17
snehasish
snehasish approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator
@snehasish snehasish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@snehasish snehasish merged commit efd03a1 into google:master Jul 1, 2024
1 check passed
@snehasish snehasish mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehasish snehasish snehasish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhoekwater @snehasish
0