Fixed race condition which results in inconsistent error code on missing copyright header. #61
Conversation
Fixed race condition which resulted in inconsistent error code on missing copyright header.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
|
Is there ANY ongoing activity for this project? I see a bunch of merge requests opened without any update. If it's not something actively maintained by anybody, I can take over or simply do my own fork. Let me know. |
| }() | ||
|
|
||
| for _, d := range flag.Args() { | ||
| walk(ch, d) | ||
| } | ||
| close(ch) | ||
| <-done | ||
| if err := <-done; err != nil { | ||
| fmt.Printf("error: %s\n", err) |
There was a problem hiding this comment.
I think the error paths do a log.Printf already, and it seems weird to print the error to stdout. Is this line needed?
Fixed race condition which resulted in inconsistent error code on missing copyright header.