-
Notifications
You must be signed in to change notification settings - Fork 183
Support for adding license to files whose name has suffix ".p4" #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Support for adding license to files whose name has suffix ".p4" #171
Conversation
Files whose names have the suffix '.p4" are typically written in the P4 programming language: https://p4.org Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
All reactions
Sorry, something went wrong.
@smolkaj @jonathan-dilorenzo These people working at Google work on projects that use the P4 programming language. |
All reactions
Sorry, something went wrong.
Thanks for contributing to addlicense! Please sync your pull request with master; I've changed filetypes to one-per-line to make future merge conflicts less likely. Please also add a test case in the |
All reactions
Sorry, something went wrong.
The error messages I see in the log for the failing "linter / lint" CI test appear to have little to do with my 1-line change, which could not have possibly by itself introduced so many linter errors. |
All reactions
Sorry, something went wrong.
Please add test cases with a before and after file in the testdata directory, and add a case to TestLicenseHeader in main_test.go. I've fixed the linter errors; another sync with the master branch might be needed to pick up the new workflow definition. |
All reactions
Sorry, something went wrong.
Successfully merging this pull request may close these issues.
Files whose names have the suffix '.p4" are typically written in the P4 programming language: https://p4.org