feat: add headers to Makefiles also #147
Jump to bottom
8000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flwyd
requested changes
Apr 26, 2025
| @@ -315,6 +315,8 @@ func licenseHeader(path string, tmpl *template.Template, data licenseData) ([]by | |||
| // handle various cmake files | |||
| if base == "cmakelists.txt" || strings.HasSuffix(base, ".cmake.in") || strings.HasSuffix(base, ".cmake") { | |||
| lic, err = executeTemplate(tmpl, data, "", "# ", "") | |||
| } else if base == "Makefile" || base == "makefile" || strings.HasSuffix(base, ".mk") { // handle various make files | |||
There was a problem hiding this comment.
cmake needs special support because it needs to look at multiple parts of the filename. I think you can just add this to the case statement above, similar to Gemfile.
| @@ -2,6 +2,11 @@ FROM golang:1.16 AS build | |||
|
|
|||
| WORKDIR /app | |||
|
|
|||
| # set env | |||
| RUN go env -w GO111MODULE=on | |||
| RUN go env -w GOPROXY=https://goproxy.cn,direct | |||
There was a problem hiding this comment.
Please revert the changes to this file.
| @@ -374,7 +376,11 @@ func hasLicense(b []byte) bool { | |||
| if len(b) < 1000 { | |||
| n = len(b) | |||
| } | |||
| return bytes.Contains(bytes.ToLower(b[:n]), []byte("copyright")) || | |||
| return bytes.Contains(bytes.ToLower(b[:n]), []byte("# copyright")) || | |||
There was a problem hiding this comment.
This change doesn't seem necessary: "# copyright" also contains the string "copyright".
| @@ -340,7 +340,7 @@ func TestLicenseHeader(t *testing.T) { | |||
| "(**\n HYS\n*)\n\n", | |||
| }, | |||
| { | |||
| []string{"cmakelists.txt", "f.cmake", "f.cmake.in"}, | |||
| []string{"cmakelists.txt", "f.cmake", "f.cmake.in", "makefile", "Makefile", "f.mk"}, | |||
There was a problem hiding this comment.
Create a separate test group for makefiles; they're different than cmake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure makefiles also get license headers.