feat: adding support for authorization at http layer (Python) #375
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I re-use the code that you supplied A2A/samples/python/common as-is for my use case.
The production env in which I work is thoroughly protected: our http gateway requires request signature.
For this purpose, I had to integrate an additional package
httpx_auth(see https://pypi.org/project/httpx-auth/ and https://github.com/Colin-b/httpx_auth)I also needed to change client.py to accept this auth signer: see commit diff for details. This changed code allows to go through our http gateway (tests are fine!)
Please, accept my PR so that I can keep using the reference code with no patch on my side.
Note: I may come back with another for the SSE part if needed when I am there in my implementation
Some similar update may have to be done for Javascript but I don't program with it.
Didier
CONTRIBUTINGGuide.nox -s formatfrom the repository root to format).