Fix python2 interpreter #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default when specifying PY2 as the `python_version` the shebang in the produced parfile is `/usr/bin/env python2` which doesn't exist on macOS (unless users have created it). This fix forces the shebang to be `/usr/bin/python2.7` which exists on all recent macOS versions. Once this project is converted to python3, we should change this to `/usr/bin/python3` instead.
|
cc @albertdai |
albertdai
approved these changes
Jun 23, 2020
|
Thanks, mind shipping a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default when specifying PY2 as the
python_versionthe shebang inthe produced parfile is
/usr/bin/env python2which doesn't exist onmacOS (unless users have created it).
This fix forces the shebang to be
/usr/bin/python2.7which exists onall recent macOS versions. Once this project is converted to python3,
we should change this to
/usr/bin/python3instead.Fixes #18