8000 docs: fix typo in action.yml by ahmadnassri · Pull Request #542 · google-github-actions/deploy-cloudrun · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: fix typo in action.yml #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHu 8000 b”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: fix typo in action.yml #542

wants to merge 1 commit into from

Conversation

ahmadnassri
Copy link
Contributor

incorrectly referencing env_vars_files instead of env_vars_file

@ahmadnassri ahmadnassri requested a review from a team as a code owner September 9, 2024 23:19
@google-cla Google CLA
Copy link
8000
google-cla bot commented Sep 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sethvargo
sethvargo requested changes Sep 10, 2024
View reviewed changes
Copy link
Member
@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahmadnassri - this part of the README is auto-generated from the action.yml - can you make the changes there and run npm run docs?

@ahmadnassri
Copy link
Contributor Author

sure thing!

@ahmadnassri
docs: fix typo in action.yml
cf692e2 
incorrectly referencing `env_vars_files` instead of `env_vars_file`

Signed-off-by: Ahmad Nassri <email@ahmadnassri.com>
8000
@ahmadnassri ahmadnassri changed the title docs: fix typo in README docs: fix typo in action.yml Sep 10, 2024
@sethvargo sethvargo mentioned this pull request Sep 10, 2024
Merged
sethvargo added a commit that referenced this pull request Sep 10, 2024
@sethvargo @ahmadnassri
fix typos in action.yml (#543)
1671c7f 
Closes #542

Rebases #542 with the generated docs, and opening as myself so that
integration tests pass.

---------

Signed-off-by: Ahmad Nassri <email@ahmadnassri.com>
Co-authored-by: Ahmad Nassri <email@ahmadnassri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo sethvargo requested changes

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadnassri @sethvargo
0