8000 Shovels can dig holes/trenches in ground turfs by pgmzeta · Pull Request #23264 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Shovels can dig holes/trenches in ground turfs #23264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2025
Merged

Shovels can dig holes/trenches in ground turfs #23264

merged 6 commits into from
May 20, 2025

Conversation

pgmzeta
Copy link
Contributor
@pgmzeta pgmzeta commented May 2, 2025 •
edited
Loading

[feature][game objects]

About the PR

Ports the 35 Below trench digging system, with some changes to support:

  • unsimmed turfs
  • grave digging
  • logging when burying mobs/special items

Adds:

  • digging tool define and use where appropriate
  • can_dig turf var to determine what turfs are diggable
  • trench sprites copied from 35 below

Things I Tested

  • terranify digging
  • azone graves (including item spawns)
  • fluid turf digging (oshan/neon/nadir) works as before, for geothermal power

Why's this needed?

Feature for Decarabia
Unique mechanics for terranify

Changelog 

(u)Bartimeus, Disturbherb, Firedhat, glowbold, and Mr.Moriaty
(+)You can dig hole
8000
s in suitable terrain with shovels.
(+)You can bury things and people in holes with shovels

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features labels May 2, 2025
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 2, 2025
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 2, 2025
TobleroneSwordfish
TobleroneSwordfish requested changes May 7, 2025
View reviewed changes
Copy link
Contributor
@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging a trench seems to break lighting on that tile permanently?
image
Tested with swamp terrainify on atlas without ambient lighting.

@pgmzeta
Copy link
Contributor Author
pgmzeta commented May 11, 2025

Digging a trench seems to break lighting on that tile permanently? image Tested with swamp terrainify on atlas without ambient lighting.

should be fixed now

@TobleroneSwordfish TobleroneSwordfish merged commit 260f1db into goonstation:master May 20, 2025
23 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2025
@robuddybot
Changelog for #23264 [skip ci]
089381a
@itchybones itchybones mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobleroneSwordfish TobleroneSwordfish TobleroneSwordfish requested changes

Assignees
No one assigned
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgmzeta @TobleroneSwordfish
0