Fix chemfire survival on simulated turfs #23803
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It made sense to package in a previous iteration, but it's just extra now. Try to remember to PR when freeze ends
frawhst
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Chemfire hotspots don't check for toxins in the air on their tile when deciding if they should self destruct.
This change makes it so that chemfires on simulated turfs will correctly heat up and apply burning to mobs which remain inside them.
Why's this needed?
Chemfires seem to be supposed to last for 3 seconds. On simulated tiles however, they currently last for only 2 seconds and self destruct before they enter their first atmos process cycle proper because they expect to see combustable gas in the atmosphere. Whereas the implication of a chemfire is surely that the chemical is what's burning.
It also means that chemfires never burn anyone unless they are actively stepped inside, thus you can 'dodge' a flashfire by standing still, which is rather wonky.
In practice this does increase the duration of almost all on-station chemfires by 50%, so reducing the default to 2 seconds may also be appropriate in terms of balance.
Testing
Tested by standing inside fires made by fireball and the vega flamethrower, and noting that burn duration increased.
Changelog