Fix overriden mindhack removal #23765
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes mindhack status being removed on the removal of an implant that has been overriden
Also move deluxe implant back up to with the regular one instead of marionette separating them.
Why's this needed?
The first surgically remove implant is always the oldest one (at least in testing) meaning the newer, actually active implant is disabled despite still being present in the player, only the most recently implanted mindhack implant will be considered "active" and remove the antag status on implant removal.
Fixes #23766
Testing
Tested with commenting out the client check and giving a dummy a mind.
Before: Antag status is removed on the first implant surgically removed.
After: Antag status is removed on the most recently implanted implant being removed.