8000 Adds ID comp access to customs lacking security access by cheekybrdy · Pull Request #23711 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds ID comp access to customs lacking security access #23711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds ID comp access to customs lacking security access #23711

wants to merge 5 commits into from

Conversation

cheekybrdy
Copy link
Contributor
@cheekybrdy cheekybrdy commented Jun 3, 2025 •
edited
Loading

About the PR

Gives ID computer access to customs without security access.

Why's this needed?

Sometimes the only ID computer is in customs on a map, which can make for fustrating HoP-less shifts when the HoS has ID access anyway. I'm assuming not giving all of sec access when customs isn't integrated with sec is a map by map design choice so I'm doing HoS access instead of letting sec flood in there every time AI calls a AA rat out.

Changelog 

(u)Cheekybrdy
(+)All Customs are accessible by the HoS now.

@cheekybrdy cheekybrdy requested review from Sord213 and flrsh as code owners June 3, 2025 01:31
@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Jun 3, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2025
pgmzeta
pgmzeta reviewed Jun 3, 2025
View reviewed changes
@JORJ949
Copy link
Contributor
JORJ949 commented Jun 3, 2025 •
edited
Loading

HoS access is special so these doors won't be able to be accesspro'd. I'd rather they got ID comp or security access, or that every map had an ID computer in the bridge.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2025
@cheekybrdy cheekybrdy changed the title Adds HoS access to customs lacking security access Adds ID comp access to customs lacking security access Jun 4, 2025
JORJ949
JORJ949 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor
@JORJ949 JORJ949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally doors should only really have one access, and ID computer access feels weird to give doors so I myself would much rather just see every bridge have an ID computer or the HoS' computer have all accesses on it, but this works as a solution.

@pgmzeta
Copy link
Contributor
pgmzeta commented Jun 5, 2025

bridges having ID computers is more Crime Compatible, there's probably room for each, especially if you replace a security/bank computer with the new one in customs by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgmzeta pgmzeta pgmzeta left review comments

@JORJ949 JORJ949 JORJ949 approved these changes

@Sord213 Sord213 Awaiting requested review from Sord213 Sord213 is a code owner

@flrsh flrsh Awaiting requested review from flrsh flrsh is a code owner

Assignees
No one assigned
Labels
A-Mapping A mapping change size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheekybrdy @JORJ949 @pgmzeta @Sord213
0