8000 Utilize PROP_ATOM_FLOATING more consistently by pgmzeta · Pull Request #23686 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Utilize PROP_ATOM_FLOATING more consistently #23686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

pgmzeta
Copy link
Contributor
@pgmzeta pgmzeta commented Jun 1, 2025

[rework][balance]

About the PR

  • Add PROP_ATOM_FLOATING to AI shell eyebots, only when active
  • Add PROP_ATOM_FLOATING to Ghostdrones (via isFlying)
  • Replace intangible checks with floating checks :
    • Landmines
    • Beartraps
    • Launcher-loaders
    • Mass Drivers
    • Floor flushers
    • Fluid puddle ripples
    • MechComp pressure sensors
  • Replace isFlying checks with floating checks
    • Lava floor
    • Sprinting FX
  • Add floating checks:
    • Diggable trenches

Why's this needed?

stuff that looks like its floating shouldn't trigger things on the floor

this lets ai eyebots and ghostdrones float over conveyors freely

Fix #23676

Changelog

(u)glowbold
(+) AI Eyebots now count as floating when active
(+) Floating objects should react more consistently with expected behavior

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 1, 2025
@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Rework Reworks a feature labels Jun 1, 2025
@RSOD404
Copy link
RSOD404 commented Jun 1, 2025

i feel like this should also apply to mechcomp pressure sensors?

@pgmzeta pgmzeta added the A-Game-Objects The point of this PR is to deal with a specific game object label Jun 2, 2025
Copy link
Contributor
@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, more consistent checks that are actually checking what they mean.

@TobleroneSwordfish TobleroneSwordfish merged commit 2e7d0a7 into goonstation:master Jun 3, 2025
24 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-Rework Reworks a feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Shell Can't Hover Over Trenches
3 participants
0