8000 Prevent underwear from poking through swimsuits/dresses by RubberRats · Pull Request #23681 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent underwear from poking through swimsuits/dresses #23681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2025
Merged

Prevent underwear from poking through swimsuits/dresses #23681

merged 9 commits into from
Jun 9, 2025

Conversation

RubberRats
Copy link
Contributor
@RubberRats RubberRats commented Jun 1, 2025 •
edited
Loading

About the PR

This PR adds a hide_underwear variable to undersuit items, which when set to true prevents the wearer's underwear from appearing on their sprite under their clothes. It is set by default on swimsuits and some dresses.

Why's this needed?

Some underwear styles have a habit of poking out from under certain outfits in ways that don't feel intended.

Changelog 

(u)RubberRats
(+)Underwear should no longer poke out from swimsuits and certain dresses

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2025
@DisturbHerb
Copy link
Contributor

If implemented, something like this should definitely be toggle-able.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Jun 1, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2025
@RubberRats RubberRats changed the title Stops underwear from poking out from swimsuits and certain dresses Toggle for underwear poking through swimsuits/dresses Jun 1, 2025
@RubberRats RubberRats added A-Clothing Deals with clothing of whatever sort C-Feature A new feature or enhancements to existing features labels Jun 1, 2025
TobleroneSwordfish
TobleroneSwordfish requested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor
@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to bikeshed this, but I really don't think it needs a toggle. There's not a lot of reason you'd ever want to show shorts under a bikini or a bra poking out around a dress and the button is just kind of weird looking UI clutter.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2025
@RubberRats RubberRats changed the title Toggle for underwear poking through swimsuits/dresses Prevent underwear from poking through swimsuits/dresses Jun 7, 2025
@TobleroneSwordfish TobleroneSwordfish merged commit 50e6054 into goonstation:master Jun 9, 2025
25 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 9, 2025
@robuddybot
Changelog for #23681 [skip ci]
abedde5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobleroneSwordfish TobleroneSwordfish Awaiting requested review from TobleroneSwordfish

Assignees
No one assigned
Labels
A-Clothing Deals with clothing of whatever sort C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubberRats @DisturbHerb @TobleroneSwordfish
0