8000 Manifold rupturing by TobleroneSwordfish · Pull Request #23646 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Manifold rupturing #23646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TobleroneSwordfish
Copy link
Contributor
@TobleroneSwordfish TobleroneSwordfish commented May 31, 2025

About the PR

Makes manifolds able to rupture and be reinforced like regular pipes.

Why's this needed?

Generating Kardashev type III amounts of power from a TEG loop made entirely out of manifolds is funny but does unfortunately need fixing.

Why did this take 200 lines of refactoring to achieve? Yea.

Changelog

(u)LeahTheTech
(*)Manifolds can now rupture and be reinforced just like regular pipes.

@TobleroneSwordfish TobleroneSwordfish added C-Balance Balance changes, buffs and nerfs A-Game-Objects The point of this PR is to deal with a specific game object labels May 31, 2025
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 31, 2025
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2025
@Nexusuxen
Copy link
Contributor

This is fair, though I would like to see some way of reinforcing pipes to handle infinite pressure, even if it was very difficult. Seeing, as you so eloquently put it, Kardashev type III orders of magnitude of power generation, is amusing and enjoyable. (I say this as Not A TEG Nerd, to be clear)

@F-e-r-n
Copy link
F-e-r-n commented May 31, 2025

as a teg nerd, i do like this but i do think there needs to be a better lategame choice than all of your pipes bursting no matter what you do, or spacing the entire TEG room so pipe bursts dont melt the entire room. Maybe the ability to fix pipes before they actually burst and spew hot plasma all over the entire room? As of right now though there's a very faint line between making enough power for the PTL and griefing the engine room.

@TobleroneSwordfish
Copy link
Contributor Author

I agree, I would like to expand on pipe reinforcement/repair in future 👍

@TobleroneSwordfish TobleroneSwordfish merged commit ea7444a into goonstation:master May 31, 2025
27 checks passed
github-actions bot pushed a commit that referenced this pull request May 31, 2025
@MegaBibarel420
Copy link

this is probably not a very good idea at this point in time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-Sprites Automatically applied on any .dmi or icons folder change size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0