8000 Table Construction QoL Improvements by nova2053 · Pull Request #23620 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Table Construction QoL Improvements #23620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

nova2053
Copy link
Contributor
@nova2053 nova2053 commented May 28, 2025

[feature][actions][qol]

About the PR

Adds a "NO_BLOCK_TABLE" flag to a couple of object types which usually spawn on tables (such as personal computers and wrestling bells). Parts-based furniture construction will ignore blockages from objects with directional blocking and, if the furniture item in question is a table, objects with the new NO_BLOCK_TABLE flag.

The following items have been given the NO_BLOCK_TABLE flag and can thus now have tables constructed under them:
KitchenHelper food mixers
Loudspeakers
Disposal outlets
Personal computers (and their frames)
Espresso machines
Coffee machines
Microwaves
Tourbot consoles
Wrestling bells
Printers
Scanners

Why's this needed?

Currently, should a table or rack on the same tile as a thindow be deconstructed, it will be unnecessarily difficult to rebuild said table/rack without also removing the thindow. This PR also solves a similar case with items which spawn on tables - most notably personal computers - preventing broken tables from being rebuilt under them.

Changelog

(u)nova2053
(+)Tables, racks, and other items which use a similar construction method can now be constructed on the same tile as thindows, sliding glass doors, and other objects with directional blocking.
(+)Tables can now be constructed under a couple more objects, such as microwaves, espresso machines, and more. See PR page for full list.

@keywordlabeler keywordlabeler bot added A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play labels May 28, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2025
@M-Earthfire
Copy link
Contributor

i would suggest adding the tag to thindows. Right now you arent able to place a table on a tile where a thin window exist.

@nova2053
Copy link
Contributor Author

i would suggest adding the tag to thindows. Right now you arent able to place a table on a tile where a thin window exist.

Tables can be placed on the tile of thindows. What I meant by "Parts-based furniture construction will ignore blockages from objects with directional blocking and, if the furniture item in question is a table, objects with the new NO_BLOCK_TABLE flag" is that, while tables will check for both whether the blocking object has the tag and whether the blocking object has directional blocking, non-tables will only check for if the blocking object has directional blocking (because putting a desktop computer, toaster, etc on top of a rack doesn't make very much sense).

@pgmzeta
Copy link
Contributor
pgmzeta commented May 30, 2025

can this be added to the little bar tv monitors too

@nova2053
Copy link
Contributor Author

can this be added to the little bar tv monitors too

The TVs in the bar lack collisions, meaning tables can be built under them anyways

@TobleroneSwordfish TobleroneSwordfish merged commit 2a6a151 into goonstation:master Jun 1, 2025
28 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0