8000 Add defines for chat speech prefixes by FlameArrow57 · Pull Request #23517 · goonstation/goonstation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add defines for chat speech prefixes #23517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2025
Merged

Add defines for chat speech prefixes #23517

merged 5 commits into from
May 20, 2025

Conversation

FlameArrow57
Copy link
Contributor

[INTERNAL][CLEANLINESS]

About the PR

Title

Why's this needed?

Code cleanliness, makes it easier to see available prefixes in one place

@keywordlabeler keywordlabeler bot added A-Internal Deals with major internal, generally non-player facing code - e.g. types C-Code-Quality Cleans up code, refactors things to be more readable or intuitive labels May 18, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 18, 2025
TobleroneSwordfish
TobleroneSwordfish requested changes May 18, 2025
View reviewed changes
FlameArrow57
FlameArrow57 commented May 18, 2025
View reviewed changes
8000
@Mister-Moriarty Mister-Moriarty self-requested a review May 18, 2025 20:40
Mister-Moriarty
Mister-Moriarty suggested changes May 18, 2025
View reviewed changes
Copy link
Contributor
@Mister-Moriarty Mister-Moriarty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that CHAT_PREFIX_ vs. SPEECH_PREFIX_ could potentially cause confusion; I'd go for PREFIX_TEXT_ or similar instead. The chat_prefix.dm file would need renamed to fit that too.

Otherwise, this is a good idea.

Mister-Moriarty
Mister-Moriarty approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor
@Mister-Moriarty Mister-Moriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to group related prefixes together in the defines file (radio prefixes vs. channel prefixes), but this is fine.

If this gets merged before wraithchat, please remind me to update the prefix for it on the PR.

Mister-Moriarty
Mister-Moriarty reviewed May 18, 2025
View reviewed changes
FlameArrow57
FlameArrow57 commented May 18, 2025
View reviewed changes
@TobleroneSwordfish TobleroneSwordfish merged commit f4e2c98 into goonstation:master May 20, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mister-Moriarty Mister-Moriarty Mister-Moriarty approved these changes

@TobleroneSwordfish TobleroneSwordfish Awaiting requested review from TobleroneSwordfish

Assignees
No one assigned
Labels
A-Internal Deals with major internal, generally non-player facing code - e.g. types C-Code-Quality Cleans up code, refactors things to be more readable or intuitive size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlameArrow57 @TobleroneSwordfish @Mister-Moriarty
0