8000 Fixing HealthCheck for Supabase by shifluxxc · Pull Request #1848 · gofr-dev/gofr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing HealthCheck for Supabase #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 19, 2025
Merged

Fixing HealthCheck for Supabase #1848

merged 10 commits into from
Jun 19, 2025

Conversation

shifluxxc
Copy link
Contributor
@shifluxxc shifluxxc commented Jun 13, 2025 •
edited
Loading

Pull Request Template

Description:

  • Fixed Fix HealthCheck in case of Supabase Connections #1840
  • Fixed tests for healthcheck functions related to Supabase SQL connections.
  • Improved logger/test setup so log assertions work as expected.
  • Addresses issues with failing tests and missing configuration for Supabase healthcheck logic.

Breaking Changes (if applicable):

  • No breaking changes introduced. All changes are backward compatible and only affect test logic and configuration handling.

Additional Information:

  • No new dependencies or external libraries were added.
  • Adjusted test utilities and logger setup to ensure logs are captured and asserted correctly.
  • Example: Now, tests pass even when DB_HOST or DB_NAME are omitted for Supabase, as they are set to default.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@shifluxxc shifluxxc changed the title test: fix healthcheck tests for Supabase connection test: fix healthcheck tests for Supabase connection #1840 Jun 13, 2025
@shifluxxc shifluxxc changed the title test: fix healthcheck tests for Supabase connection #1840 test: fix healthcheck tests for Supabase connection Jun 13, 2025
vikash
vikash reviewed Jun 16, 2025
View reviewed changes
@coolwednesday
Copy link
Contributor

@shifluxxc , Please ensure that the PR title clearly reflects the primary fix or feature you're introducing.
Also, we kindly request that you do not start working on an issue unless it has been assigned to you. This helps prevent duplication of effort and avoids situations where multiple contributors are unknowingly working on the same task in parallel.

@Umang01-hash
Copy link
Member

@shifluxxc Please comment on the 8000 issue that you want to work on it so that i can assign this issue to you. Thanks

@shifluxxc shifluxxc changed the title test: fix healthcheck tests for Supabase connection Fix : Supabase connection healthcheck tests and logging Jun 16, 2025
coolwednesday
coolwednesday reviewed Jun 16, 2025
View reviewed changes
@shifluxxc
Copy link
Contributor Author

@shifluxxc , Please ensure that the PR title clearly reflects the primary fix or feature you're introducing. Also, we kindly request that you do not start working on an issue unless it has been assigned to you. This helps prevent duplication of effort and avoids situations where multiple contributors are unknowingly working on the same task in parallel.

I will make sure to wait for assignment before picking up issues . I updated the PR title and also removed the setOut function from mocklogger.

@coolwednesday
Copy link
Contributor

@shifluxxc , if you've addressed the review comments, please mark them as resolved. This helps move your PR toward merging. If the reviewer disagrees or has further suggestions, they will leave additional comments or update their review accordingly.

@shifluxxc
Copy link
Contributor Author

@shifluxxc , if you've addressed the review comments, please mark them as resolved. This helps move your PR toward merging. If the reviewer disagrees or has further suggestions, they will leave additional comments or update their review accordingly.

Done 👍

coolwednesday
coolwednesday suggested changes Jun 17, 2025
View reviewed changes
@coolwednesday
Copy link
Contributor
coolwednesday commented Jun 17, 2025 •
edited
Loading

I have tested the PR, it works fine. Below are the screenshots for the reference of other reviewers. However there is no logging and traces for HealthCheck in any of the SQL supported datasources addition(I checked for mysql local instance and supabase). I feel that is out of the scope of this PR and can be handled in another PR.

@shifluxxc, please change the PR's name to : "Fixing HealthCheck for Supabase"

Screenshot 2025-06-17 at 1 18 09 PM Screenshot 2025-06-17 at 1 18 20 PM

@coolwednesday coolwednesday mentioned this pull request Jun 17, 2025
Closed
@shifluxxc shifluxxc changed the title Fix : Supabase connection healthcheck tests and logging Fix : Fixing HealthCheck for Supabase Jun 17, 2025
@shifluxxc shifluxxc changed the title Fix : Fixing HealthCheck for Supabase Fixing HealthCheck for Supabase Jun 17, 2025
@shifluxxc
Copy link
Contributor Author

I have tested the PR, it works fine. Below are the screenshots for the reference of other reviewers. However there is no logging and traces for HealthCheck in any of the SQL supported datasources addition(I checked for mysql local instance and supabase). I feel that is out of the scope of this PR and can be handled in another PR.

@shifluxxc, please change the PR's name to : "Fixing HealthCheck for Supabase"

Screenshot 2025-06-17 at 1 18 09 PM Screenshot 2025-06-17 at 1 18 20 PM

I have tested the PR, it works fine. Below are the screenshots for the reference of other reviewers. However there is no logging and traces for HealthCheck in any of the SQL supported datasources addition(I checked for mysql local instance and supabase). I feel that is out of the scope of this PR and can be handled in another PR.

@shifluxxc, please change the PR's name to : "Fixing HealthCheck for Supabase"

Screenshot 2025-06-17 at 1 18 09 PM Screenshot 2025-06-17 at 1 18 20 PM

Done

vikash
vikash reviewed Jun 17, 2025
View reviewed changes
@Umang01-hash
Copy link
Member
Screenshot 2025-06-18 at 9 04 03 AM

@shifluxxc You have the following linter issues in your PR. Please resolve them so that we can go ahead and re-review your PR.

@shifluxxc
Copy link
Contributor Author
Screenshot 2025-06-18 at 9 04 03 AM @shifluxxc You have the following linter issues in your PR. Please resolve them so that we can go ahead and re-review your PR.

Sir I have resolved the linting , you can review the changes

@Umang01-hash Umang01-hash merged commit 202aad4 into gofr-dev:development Jun 19, 2025
16 checks passed
@shifluxxc shifluxxc deleted the fix-healthCheck-supabase-connection branch June 19, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikash vikash vikash left review comments

@Umang01-hash Umang01-hash Umang01-hash approved these changes

@coolwednesday coolwednesday coolwednesday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix HealthCheck in case of Supabase Connections
5 participants
@shifluxxc @coolwednesday @Umang01-hash @vikash @aryanmehrotra
0