New Error Type: ErrorRecordNotFound #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les" This reverts commit 64d3fb7.
coolwednesday
approved these changes
Jun 11, 2025
Umang01-hash
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Created new error type ErrorRecordNotFound for No Records Found in DB scenario. This should be used by the store layer in case there are no rows returned for a given ID (where a single row was expected).
Breaking Changes (if applicable):
N/A
Additional Information:
Errors in the datastore package should not be aware of the http response codes, thereby should not implement the StatusCode method. While the status code method has been implemented for now to provide consistency, it should be removed eventually. Removing the StatusCode method would be a breaking change.
Checklist:
goimportandgolangci-lint.