8000 added Pinecone as datasource support by Praiseson6065 · Pull Request #1809 · gofr-dev/gofr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added Pinecone as datasource support #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

added Pinecone as datasource support #1809

wants to merge 6 commits into from

Conversation

Praiseson6065
Copy link

Description:

This PR implements comprehensive Pinecone vector database support for the GoFr framework, addressing the need for modern vector database integration in AI/ML applications. The implementation follows GoFr's established patterns for datasource integration and provides a complete, production-ready Pinecone client.

Key Features Added:

  • Complete Pinecone Integration: Full support for Pinecone vector database operations including index management, vector operations (upsert, query, fetch, delete), and health monitoring
  • Official SDK Integration: Uses the official Pinecone Go SDK (v3) for reliable and up-to-date API compatibility
  • Observability Suite: Comprehensive logging, metrics, and distributed tracing support following GoFr's observability standards
  • Health Monitoring: Built-in health checks with detailed connection status and index information
  • Modular Architecture: Clean separation of concerns with dedicated managers for connections, indexes, vectors, spans, and health checks
  • Testing Infrastructure: Complete test coverage including mock implementations for reliable testing
  • Type Safety: Strongly typed interfaces and comprehensive error handling

Components Implemented:

  • Core client with connection management
  • Index operations (list, describe, create, delete)
  • Vector operations (upsert, query, fetch, delete, deleteAll)
  • Health check system with connectivity testing
  • Structured logging with operation-specific details
  • Metrics collection for performance monitoring
  • Distributed tracing with OpenTelemetry integration
  • Mock implementations for testing

Breaking Changes (if applicable):

  • None. This is a new datasource addition that doesn't affect existing functionality.

Additional Information:

  • Dependencies: Integrates github.com/pinecone-io/go-pinecone/v3/pinecone for official SDK support
  • Architecture: Follows GoFr's interface-driven design pattern, enabling easy testing and extensibility
  • Observability: Full integration with GoFr's logging, metrics, and tracing infrastructure
  • Configuration: Simple configuration requiring only API key for connection
  • Documentation: Comprehensive interface documentation and usage examples

Files Added:

  • interface.go - Core interfaces and type definitions
  • pinecone.go - Main client implementation
  • connection.go - Connection management
  • index_manager.go - Index operations
  • vector_manager.go - Vector operations
  • health.go - Health check implementation
  • logger.go - Structured logging
  • metrics.go - Metrics interface
  • span_manager.go - Tracing support
  • Complete test suite with mocks and comprehensive coverage

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

@Umang01-hash
Copy link
Member
Umang01-hash commented Jun 6, 2025 •
edited
Loading

@Praiseson6065 You have included PineCone in the GoFr's go mod only. All th datasources have their separate go.mod files. You can take reference from them.

Also the implementation is incomplete. Go thorugh this breif documentation to get the idea: https://github.com/gofr-dev/gofr/tree/development/pkg/gofr/datasource

@Praiseson6065
Copy link
Author

@Umang01-hash, please verify whether the implementation of the Pinecone DB as a data source is complete.

@Umang01-hash
Copy link
Member

@Praiseson6065 there are a lot of linter errors and also merge conflicts in this PR. Can you please resolve the,. Try to run linter locally first to check and see if it passes before pushing the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Praiseson6065 @Umang01-hash
0