8000 Feat: add gRPC .WithReflection() method by ace3 · Pull Request #1807 · gofr-dev/gofr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat: add gRPC .WithReflection() method #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 19, 2025
Merged

Feat: add gRPC .WithReflection() method #1807

merged 14 commits into from
Jun 19, 2025

Conversation

ace3
Copy link
Contributor
@ace3 ace3 commented Jun 4, 2025 •
edited
Loading

Description:

  • Added a unit test for the GetGRPCServer method in the App struct.
  • The new test ensures that the method returns a non-nil *grpc.Server instance after initialization.
  • This improves test coverage and validates the public API for accessing the underlying gRPC server.

Breaking Changes (if applicable):

  • No breaking changes are introduced by this PR.
  • All existing functionality remains backward compatible.

Additional Information:

  • The test follows the existing test structure and uses testify/require for assertions.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

@ace3
Copy link
Contributor Author
ace3 commented Jun 4, 2025 •
edited
Loading

This PR is used for my use case to enable the gRPC reflection of the service.

Screenshot 2025-06-04 at 10 10 13 
import (
	"google.golang.org/grpc/reflection"
)

func main() {

	app := gofr.New()

	greetServer.RegisterGreetServerWithGofr(app, greetServer.NewGreetGoFrServer())

        app.WithReflection()
	app.Run()
}

@ace3 ace3 changed the title Feat: add GetGRPCServer public method Feat: add gRPC .WithReflection() method Jun 5, 2025
@coolwednesday
Copy link
Contributor

@ace3, Just a heads-up:
Please avoid making any new changes directly to the you fork's development branch. Any future branches created from development will inherit its commit history — including any recent changes. This can cause confusion as those commits will appear in your new branches as well.

Let’s keep development clean to ensure a smooth workflow going forward.

coolwednesday
coolwednesday suggested changes Jun 10, 2025
View reviewed changes
coolwednesday
coolwednesday reviewed Jun 16, 2025
View reviewed changes
@Umang01-hash
Copy link
Member

@ace3 Just a reminder you have a review comment left from @coolwednesday. Let's resolve it so that we can go ahead and merge your PR.

@ace3
Copy link
Contributor Author
ace3 commented Jun 18, 2025

@ace3 Just a reminder you have a review comment left from @coolwednesday. Let's resolve it so that we can go ahead and merge your PR.

hi, i just pushed the changes.

@Umang01-hash Umang01-hash merged commit c77bb46 into gofr-dev:development Jun 19, 2025
16 checks passed
< 70D9 /div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umang01-hash Umang01-hash Umang01-hash approved these changes

@coolwednesday coolwednesday coolwednesday approved these changes

@kairavaibhav kairavaibhav kairavaibhav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace3 @coolwednesday @Umang01-hash @kairavaibhav
0