8000 token: disallow multiple tokens with same name by frodeaa · Pull Request #5820 · gogs/gogs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

token: disallow multiple tokens with same name #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2019
Merged

token: disallow multiple tokens with same name #5820

merged 4 commits into from
Oct 15, 2019

Conversation

frodeaa
Copy link
Contributor
@frodeaa frodeaa commented Oct 13, 2019

Fail with 422 Unprocessable Entity if the token name
already exist

ref: #5587

@frodeaa
api/v1: don't allow multiple tokens with same name
7f11423 
Fail with 422 Unprocessable Entity if the token name
already exist

ref: gogs#5587
unknwon
unknwon requested changes Oct 14, 2019
View reviewed changes
@unknwon unknwon added status: needs feedback Tell me more about it status: reviewed It has been reviewed by maintainers status: waits for review It is waiting to be reviewed by maintainers and removed status: needs feedback Tell me more about it status: reviewed It has been reviewed by maintainers labels Oct 14, 2019
@unknwon unknwon self-requested a review October 14, 2019 21:25
unknwon
unknwon requested changes Oct 14, 2019
View reviewed changes
@unknwon unknwon added status: needs feedback Tell me more about it status: reviewed It has been reviewed by maintainers and removed status: waits for review It is waiting to be reviewed by maintainers labels Oct 14, 2019
@frodeaa frodeaa force-pushed the duplicate-token-names branch 2 times, most recently from 700c08e to 8104772 Compare October 14, 2019 22:56
@unknwon
Copy link
Member
unknwon commented Oct 15, 2019

Thank you!

@unknwon unknwon removed the status: needs feedback Tell me more about it label Oct 15, 2019
@unknwon unknwon changed the title api/v1: don't allow multiple tokens with same name token: disallow multiple tokens with same name Oct 15, 2019
@unknwon unknwon merged commit ffbb0f6 into gogs:develop Oct 15, 2019
unknwon added a commit that referenced this pull request Oct 15, 2019
@unknwon
models/token: generate bindata and simplify code (#5820)
a04de87
@unknwon unknwon mentioned this pull request Oct 15, 2019
Closed
@frodeaa frodeaa deleted the duplicate-token-names branch November 10, 2019 15:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unknwon unknwon unknwon approved these changes

Assignees
No one assigned
Labels
status: reviewed It has been reviewed by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frodeaa @unknwon
0