10000 fix(database/gdb): Resolved the schema error in the database output log when using the database sharding feature by LanceAdd · Pull Request #4319 · gogf/gf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(database/gdb): Resolved the schema error in the database output log when using the database sharding feature #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(database/gdb): Resolved the schema error in the database output log when using the database sharding feature #4319

wants to merge 1 commit into from

Conversation

LanceAdd
Copy link
Contributor

error log

2025-06-18T15:36:08.315+08:00 [DEBU] {10a3b0cfd9124a186b89b07f50e67ce6} [  0 ms] [default] [db_0] [rows:1  ] SELECT `id`,`custom_name` FROM `custom` WHERE `id`=1 LIMIT 1

2025-06-18T15:36:09.259+08:00 [DEBU] {10a3b0cfd9124a186b89b07f50e67ce6} [  1 ms] [default] [db_0] [rows:1  ] SELECT `id`,`custom_name`,`remark`FROM `custom` WHERE `id`=2 LIMIT 1

right log

2025-06-18T15:36:08.315+08:00 [DEBU] {10a3b0cfd9124a186b89b07f50e67ce6} [  0 ms] [default] [db_0] [rows:1  ] SELECT `id`,`custom_name` FROM `custom` WHERE `id`=1 LIMIT 1

2025-06-18T15:36:09.259+08:00 [DEBU] {10a3b0cfd9124a186b89b07f50e67ce6} [  1 ms] [default] [db_1] [rows:1  ] SELECT `id`,`custom_name`,`remark`FROM `custom` WHERE `id`=2 LIMIT 1


type DbShardingRule struct {
}

func (d *DbShardingRule) SchemaName(ctx context.Context, config gdb.ShardingSchemaConfig, value any) (string, error) {
	if name, ok := value.(string); ok && (len(name) > 0) && gstr.HasPrefix(name, config.Prefix) {
		return name, nil
	}
	return "default", nil
}

func (d *DbShardingRule) TableName(ctx context.Context, config gdb.ShardingTableConfig, value any) (string, error) {
	return "", nil
}

config := gdb.ShardingConfig{
		Schema: gdb.ShardingSchemaConfig{
			Enable: true,
			Prefix: "db_",
			Rule:   &DbShardingRule{},
		},
	}
dao.Custom.Ctx(ctx).Sharding(config).ShardingValue("db_0").Where("id", 1).One()
dao.Custom.Ctx(ctx).Sharding(config).ShardingValue("db_1").Where("id", 2).One()

我有两个完全一样的数据库db_0和db_1，两个custom表里都只有一条数据，id是1和2，执行上面两条查询得的结果是正确的，
输出日志中应该分别是[default] [db_0]和[default] [db_1]，但是实际输出的都是[default] [db_0]，
查看具体代码实现，该日志由Core实例中获取group和schema构成，而实际执行sql时如果使用了分库特性那么执行sql的link会使用当前面schema重新生成，但是没有重新赋给Core实例，所以输出日志的时候还是错的，只需要在生成link后生成日志前把schema赋给Core就行，方法执行完成后defer将schema重置回去，防止有人重复使用同一个gdb对象造成困扰
SCR-20250618-ovoc
SCR-20250618-ovvk
SCR-20250618-ozsu
SCR-20250618-ozwj

@hailaz hailaz added the bug It is confirmed a bug, but don't worry, we'll handle it. label Jun 20, 2025
@hailaz hailaz requested a review from gqcn June 23, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn Awaiting requested review from gqcn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug It is confirmed a bug, but don 46FD 't worry, we'll handle it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LanceAdd @hailaz
0