8000 Remove unmaintained extensions by keremc · Pull Request #30 · goblint/cil · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unmaintained extensions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2021
Merged

Remove unmaintained extensions #30

merged 6 commits into from
Apr 23, 2021

Conversation

keremc
Copy link
@keremc keremc commented Apr 20, 2021

This removes the extensions:

  • simplemem
  • canonicalize (makes C code C++ compliant, not useful for Goblint)
  • llvm (not useful for Goblint, also probably broken)
  • heapify ("move stack-allocated arrays to the heap", code instrumentation, not useful for Goblint)
  • oneret
  • logcalls (code instrumentation, not useful for Goblint)
  • inliner (unfinished as far as I can tell)
  • partial (unsound in some cases, see thesis)
  • blockinggraph (unfinished & not very useful, see thesis)
  • sfi (code instrumentation, not useful for Goblint)
  • simplify
  • cqualann
  • logwrites (code instrumentation, not useful for Goblint)
  • epicenter ("remove all functions except those within some number", code instrumentation, probably not useful for Goblint)
  • ccl ("CCured Lite")

See #28

@michael-schwarz michael-schwarz self-assigned this Apr 20, 2021
@michael-schwarz
Copy link
Member

Can you please also modify the test suite such that the removed features are not tested, and it passes?

@keremc
Copy link
Author
keremc commented Apr 20, 2021

Can you please also modify the test suite such that the removed features are not tested, and it passes?

OK. I deleted the tests related to "simplify". Some tests were failing because of the --domakeCFG option which was implemented in "partial", so I moved that part into a new extension called "makecfg".

@michael-schwarz
Copy link
Member

@vogler @sim642 @jerhard Any objections to removing these?

@vogler
Copy link
Collaborator
vogler commented Apr 20, 2021

No. Maybe cleanup the Readme and link this PR (or make a table/list that summarizes the diff to upstream (removed stuff, C99 features, fixed bugs, ?)).

@sim642
Copy link
Member
sim642 commented Apr 20, 2021

I agree, updating the README and listing some bigger changes we've made could be useful.

@michael-schwarz
Copy link
Member

Yes, good point! Can you also make the changes to the README in this PR @keremc?

Apart from the things in this PR, the substantial changes are:

@keremc
Copy link
Author
keremc commented Apr 23, 2021

OK, I updated the README to list the improvements made in goblint-cil and mentioned the opam package in the quick start. It is quite outdated at the moment, but I think @michael-schwarz plans to push an update.

@michael-schwarz michael-schwarz merged commit 069df74 into develop Apr 23, 2021
@sim642 sim642 deleted the remove-unmaintained-extensions branch May 30, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michael-schwarz michael-schwarz

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keremc @michael-schwarz @vogler @sim642
0