make free trial per-account #225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't working: the free trial setting is always getting saved as false. Edit: If I manually change the value of IsFreeTrial to true in the accounts.json file, it will show up in the list, but after selecting it, a new entry with IsFreeTrial set to false will be added. |
rankynbass
suggested changes
May 7, 2025
| @@ -144,7 +145,7 @@ private void ProcessLogin(LoginAction action) | |||
|
|
|||
| App.Settings.IsAutologin = this.loginFrame.IsAutoLogin; | |||
|
|
|||
| var result = await Login(loginFrame.Username, loginFrame.Password, loginFrame.IsOtp, loginFrame.IsSteam, false, action).ConfigureAwait(false); | |||
| var result = await Login(loginFrame.Username, loginFrame.Password, loginFrame.IsOtp, loginFrame.IsSteam, loginFrame.IsFreeTrial, false, action).ConfigureAwait(false); | |||
There was a problem hiding this comment.
These arguments are in the wrong order. If you look below to the Login() Task, doingAutoLogin follows isSteam, and then IsFreeTrail. Here, the loginFrame.IsFreeTrial is being passed as the doingAutoLogin, and isFreeTrial is always false.
Co-authored-by: Rankyn Bass <109918887+rankynbass@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied
2BAC
right now. Please check back later.
A lot of users have been confused over the free trial setting, so I've moved it to somewhere more visible