use NativeLibrary to try loading libgamemodeauto.so.0 #68

navi-desu · 2023-08-12T21:03:02Z

this removes the reliance on path checking, instead moving it to the (appropriate) dlopen(3) call that dotnet does under the hood. that call loads libs based on different variables that are set by the user. thus allowing the user to have the lib in different paths scanned by /etc/ld.so.cache, or override it by setting LD_LIBRARY_PATH.

this issue should fix #67 (and the associated gentoo bug https://bugs.gentoo.org/911936)

i tested this patch on my gentoo machine, but not in flatpaks, and i am unsure if flatpaks have the /app/lib in it's ld path. if anyone does now, please let me now. depending on it, the file check for the flatpak specific path might need to be re-introduced

this removes the reliance on path checking, instead moving it to the (appropriate) dlopen(3) call that dotnet does under the hood. that call loads libs based on different variables that are set by the user. thus allowing the user to have the lib in different paths scanned by /etc/ld.so.cache, or override it by setting LD_LIBRARY_PATH. Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>

Blooym

Tested against a flatpak build and from dotnet run inside of a Fedora Workstation 38 container, game loads perfectly fine with gamemode detected and used on boot.

Blooym self-requested a review August 12, 2023 22:20

Blooym approved these changes Aug 12, 2023

View reviewed changes

Blooym merged commit 8f1933d into goatcorp:main Aug 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use NativeLibrary to try loading libgamemodeauto.so.0 #68

use NativeLibrary to try loading libgamemodeauto.so.0 #68

use NativeLibrary to try loading libgamemodeauto.so.0 #68

use NativeLibrary to try loading libgamemodeauto.so.0 #68

Conversation

Choose a reason for hiding this comment