feat: Deprecate IGameNetwork #2241
Conversation
Co-authored-by: Haselnussbomber <mail@haselnussbomber.de>
2c3423c to
968fc24
Compare
|
In response to a Discord comment:
I'm of the opinion that there's no longer any valid use case for this service. Even were we to move the hooks to provide deobfuscated information, there's very little value to providing such an API surface. There is a possibility that it may still be beneficial to have a singular hook interacting with the relevant function(s), but in practice this seems minimal at best. Nearly every plugin that would use this service can be better served hooking elsewhere, leaving the general-purpose methods untouched. While the singular-hook argument also means that events can be managed in a cleaner fashion and we can prevent plugins from bringing down the entire stack, it's still ultimately a plugin developer's responsibility to test their code and make sure things don't crash. This method already passed a |
|
I only really use https://github.com/rekyuu/StanleyParableXiv/blob/main/StanleyParableXiv/Events/PvpEvent.cs#L334 PingPlugin and DeepDungeonTracker are obviously way more important though.
EDIT: I am now caught up on Discord and am now aware that |
|
Anything currently using the network could track down one of the functions further the call tree from ProcessZonePacketDown using IDA/Ghidra and hook that instead. You've still gotta decode the network packets depending on how far down you go but there's definitely alternatives. |
This PR is a proposal to remove the
IGameNetworkservice from Dalamud. With changes in Patch 7.2 (namely, additional packet obfuscation), this service no longer really provides useful data in some cases. In general, Dalamud has encouraged developers move away from opcode management in favor of hook(s) in the appropriate locations, and this solidifies that decision.This service may still be used by certain plugins. As such, we are seeking input from relevant community members who may still have some use for these APIs about the deprecation path here.
Identified Uses:
At this time, the internal service is not planned to be deprecated, as it's still used for the debug window. This feature is still deemed beneficial as it can be used to identify whether something does (or doesn't) send a network request.