8000 Support Go 1.23+ only by tchssk · Pull Request #3711 · goadesign/goa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support Go 1.23+ only #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Support Go 1.23+ only #3711

merged 2 commits into from
May 19, 2025

Conversation

tchssk
Copy link
Member
@tchssk tchssk commented May 19, 2025 •
edited
Loading
  • There is no need to specify a toolchain.
  • There is no need to test for Go 1.20 and 1.21.
    • They should be removed from required status checks.

@tchssk tchssk marked this pull request as ready for review May 19, 2025 11:46
@tchssk tchssk requested a review from Copilot May 19, 2025 11:46
Copilot
Copilot AI reviewed May 19, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to require Go 1.23+ only by removing the explicit toolchain directive and dropping older versions from CI.

  • Remove toolchain directive from go.mod
  • Restrict CI matrix to Go 1.23 and 1.24

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Removed toolchain go1.23.6 since only Go 1.23+ is needed
.github/workflows/test.yml Dropped Go 1.21 and 1.22 from the test matrix

@raphael
Copy link
Member
raphael commented May 19, 2025

Great, thank you! I removed Go 1.21 and Go 1.22 from the required checks.

@raphael raphael merged commit d32214a into goadesign:v3 May 19, 2025
9 checks passed
@tchssk tchssk deleted the gomod-toolchain-remove branch May 20, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchssk @raphael
0