8000 Removing empty-task list validation by kritika-singh3 · Pull Request #8177 · gocd/gocd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removing empty-task list validation #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

Removing empty-task list validation #8177

merged 1 commit into from
May 27, 2020

Conversation

kritika-singh3
Copy link
Contributor

Description: as there is no corresponding check at the API side

@kritika-singh3
Removing empty-task list validation
5265062 
 - as there is no corresponding check at the API side
@kritika-singh3 kritika-singh3 added this to the Release 20.4.0 milestone May 27, 2020
@maheshp maheshp merged commit e63a99a into gocd:master May 27, 2020
@kritika-singh3 kritika-singh3 deleted the remove-empty-task-list-validation branch May 27, 2020 04:39
@marques-work
Copy link
Member

There may not be a validation on the server side, but I think it makes sense to keep the validation for UX. Originally, it was put in for the UX improvements to "add pipeline". New users would be able to erroneously create jobs that do nothing.

Is there any other reason this was removed? It feels like a bug on the server side to allow taskless jobs. I would rather have chosen to make the server side match this validation.

/cc @arvindsv @maheshp @GaneshSPatil, WDYT?

kritika-singh3 added a commit to kritika-singh3/gocd that referenced this pull request May 28, 2020
@kritika-singh3
Revert "Merge pull request gocd#8177 from kritika-singh3/remove-empty…
6d4caf3 
…-task-list-validation"

This reverts commit e63a99a, reversing
changes made to a82dee7.

 - this is reverted as the validation makes sense.
@kritika-singh3 kritika-singh3 mentioned this pull request May 28, 2020
Merged
kritika-singh3 added a commit that referenced this pull request May 28, 2020
@kritika-singh3
Revert "Merge pull request #8177 from kritika-singh3/remove-empty-tas…
5553066 
…k-list-validation"

This reverts commit e63a99a, reversing
changes made to a82dee7.

 - this is reverted as the validation makes sense.
This was referenced Jun 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pipeline-config-spa
Projects
None yet
Milestone
Release 20.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kritika-singh3 @marques-work @maheshp
0