[Timestamp] Use microsecond precision to support full range of BigQuery timestamps #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff
8000
@@
## main #133 +/- ##
==========================================
+ Coverage 45.82% 45.88% +0.06%
==========================================
Files 47 47
Lines 17800 17820 +20
==========================================
+ Hits 8156 8176 +20
+ Misses 8182 8180 -2
- Partials 1462 1464 +2 |
goccy
reviewed
Jan 29, 2024
| return time.Time{}, fmt.Errorf("invalid timestamp string (multiple delimiters) %s", v) | ||
| } | ||
| seconds, err := strconv.ParseInt(parts[0], 10, 64) | ||
| micros := int64(0) |
There was a problem hiding this comment.
Since err variable may be overwritten by L26, so error handling should be done here.
seconds, err := ...
if err != nil {
return time.Time{}, err
}
micros := int64(0)
timestamp.go
Outdated
| for len(microsString) < 6 { | ||
| microsString += "0" | ||
| } | ||
| micros, err = strconv.ParseInt(parts[1], 10, 64) |
There was a problem hiding this comment.
m, err = strconv.ParseInt(parts[1], 10, 64)
if err != nil {
return time.Time{}, err
}
micros = m
|
Thank you for your contribution ! LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously encoding / decoding timestamp values using nanoseconds, which only covers a partial range of the supported timestamps as we hit the lowest / highest allowed int64 values more quickly.
Since BigQuery only supports microsecond precision, this switches us to it.
Closes #132