Harden string functions when NULL is passed #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 45.40% 45.78% +0.38%
==========================================
Files 44 44
Lines 17544 17620 +76
==========================================
+ Hits 7966 8068 +102
+ Misses 8131 8120 -11
+ Partials 1447 1432 -15 |
|
Hi @goccy, is there anything I can do to move these changes forward? Thank you! |
|
Bumping this issue @goccy |
goccy
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when using some string functions, like
LEFTorREGEXP_REPLACE, if one of the values passed to the function was NULL we would receive an error like:This updates the string functions to more consistently check for NULL parameters and return the correct value, either NULL or an empty array, depending on whether the function returns a single value or an array.