Support implicit null #727
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 77.95% 77.94% -0.02%
==========================================
Files 22 22
Lines 7993 7998 +5
==========================================
+ Hits 6231 6234 +3
- Misses 1347 1349 +2
Partials 415 415 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an ImplicitNullType token to enable reversible conversion of implicit nulls by omitting the "null" string during output.
- Added a new ImplicitNullType constant and its corresponding string representation.
- Updated parser, context, and AST methods to process implicit null tokens.
- Modified tests to account for the new implicit null behavior.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| token/token.go | Adds a new constant ImplicitNullType and its string mapping. |
| parser/token.go | Includes ImplicitNullType in scalar type handling. |
| parser/parser.go | Replaces createNullToken calls with createImplicitNullToken in various parse methods. |
| parser/context.go | Refactors token creation by renaming createNullToken to createImplicitNullToken. |
| ast/ast.go | Updates NullNode and AnchorNode string representations to distinguish implicit nulls. |
| parser_test.go | Adjusts test cases to align with the reversible conversion of implicit null values. |
| @@ -627,6 +627,12 @@ func (n *NullNode) GetValue() interface{} { | |||
|
|
|||
| // String returns `null` text | |||
| func (n *NullNode) String() string { | |||
| if n.Token.Type == token.ImplicitNullType { | |||
There was a problem hiding this comment.
Consider adding a clarifying comment here to explain why an implicit null token returns its comment string (if available) rather than a fixed 'null' value. This will help maintainers understand the reversible conversion behavior for implicit null tokens.
Copilot uses AI. Check for mistakes.
resolve #710
Add
ImplicitNullTypeas a token type.ImplicitNullTypeis used during the parser phase when inserting a null token. If ast.NullNode holds this token, the "null" string will be omitted when converted to a string. This enables reversible conversion of implicit nulls.