Bump rack and webrick versions #108

stephenbinns · 2024-07-23T07:39:41Z

This prevents upgrades in upstream gems so isn't ideal

This prevents upgrades in upstream gems

que.gemspec

Tabby

bin/que needs updating to use the new Rack 3.x API

Lines 153 to 159 in 03ecfdc

    
           Rack::Handler::WEBrick.run( 
        
             app, 
        
             Host: "0.0.0.0", 
        
             Port: options.metrics_port, 
        
             Logger: WEBrick::Log.new("/dev/null"), 
        
             AccessLog: [], 
        
           )

Needs to look more like the Rack 3.x branch of this: https://github.com/gocardless/gc-pubsub-consumer/blob/a31844ec04d31f20ccc1aa5b597c5f5c61898607/lib/gc_pubsub_consumer/metrics_exposer.rb#L54-L70

Tabby · 2024-07-23T09:05:50Z

This also suggests we're not testing that bin/que actually works in CI 🙃

We were also missing some dependencies so these have been added too.

We can load it for CI but for the benchmarking step we push a docker image which can't be built without adding the token in. As this is a public repo I'm not sure we want to add it in.

We need to establish a connection to the database manually

stephenbinns · 2024-08-06T09:39:17Z

This also suggests we're not testing that bin/que actually works in CI 🙃

This should all be addressed now, bit of a pain but we now run bin/que in a CI step with the metrics enabled so should be testing enough for us to have confidence in the command

Tabby

Thanks for fixing that! Don't think it needed to maintain 2.x compatibility, but can't hurt :)

Bump rack and webrick versions

03ecfdc

This prevents upgrades in upstream gems

ameykusurkar reviewed Jul 23, 2024

View reviewed changes

que.gemspec Outdated Show resolved Hide resolved

Tabby requested changes Jul 23, 2024

View reviewed changes

stephenbinns added 6 commits August 6, 2024 10:00

Support rack 3 and add smoke test

381291a

We were also missing some dependencies so these have been added too.

Try bundle exec

502ecfc

Make CI check more realistic

5dd5056

Remove dependency on promgcstat as this is a private gem

3b0cc6e

We can load it for CI but for the benchmarking step we push a docker image which can't be built without adding the token in. As this is a public repo I'm not sure we want to add it in.

Fixup CI step

5cb524a

We need to establish a connection to the database manually

Add db migrate to smoke testing

7ac29ce

stephenbinns requested a review from Tabby August 6, 2024 09:52

Tabby approved these changes Aug 7, 2024

View reviewed changes

stephenbinns merged commit 8519451 into master Aug 7, 2024
10 checks passed

stephenbinns deleted the upgrade-rack-webrick branch August 7, 2024 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rack and webrick versions #108

Bump rack and webrick versions #108

	Rack::Handler::WEBrick.run(
	app,
	Host: "0.0.0.0",
	Port: options.metrics_port,
	Logger: WEBrick::Log.new("/dev/null"),
	AccessLog: [],
	)

Bump rack and webrick versions #108

Bump rack and webrick versions #108

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment