8000 Additional media protection based on Course or Membership by brianhogg · Pull Request #2894 · gocodebox/lifterlms · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Additional media protection based on Course or Membership #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service a 8000 nd privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: dev
Choose a base branch
from
Open

Additional media protection based on Course or Membership #2894

wants to merge 59 commits into from

Conversation

brianhogg
Copy link
Contributor

Description

Ability to protect a file in the media library to only be accessible by a logged in user who is enrolled in a Course or Membership.

How has this been tested?

Manually

Screenshots

CleanShot 2025-03-14 at 5  34 57@2x
CleanShot 2025-03-14 at 5  36 57@2x
CleanShot 2025-03-14 at 5  37 20@2x

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

brianhogg added 30 commits March 4, 2025 12:12
@brianhogg
WIP: Adding initial field. Need to initialize the select2 later.
3db2c0d
@brianhogg
WIP: This works but only the first one when you click 'Replace' on an…
e72f135 
… existing image.
@brianhogg
This works, but needs to have the selected value (if any) and set the…
fdfaefe 
… post type to course/membership.
@brianhogg
WIP: Just need to save the data, and then "move" the attachment (and …
509e0df 
…any thumbnails) to the protected folder.
@brianhogg
WIP: Saving the selected course/membership ID, and moving the already…
c39cc4b 
… uploaded file (and related sizes if an image) to the lifterlms protected folder.
@brianhogg
Removing logs.
de72601
@brianhogg
Adding authorization check for chosen course/membership ID. Removing …
7001aae 
…error logs.
@brianhogg
WIP: Listens for change event and can see URL change. If value is cor…
2341a99 
…rect we can just update the value of the text input manually.
@brianhogg
Replace the file URL if it's changed, ie. when the file is first prot…
deef1d5 
…ected.
@brianhogg
Show existing selected option if any.
9595075
@brianhogg
Adding todo
cec60df
@brianhogg
Changelog.
19db110
@brianhogg
Only serve file from our code if the auth filter meta exists, and onl…
0b7fd52 
…y fetch an image if the size or icon param exists. Also check that it's an attachment post before serving it.
@brianhogg
Update version of e2e test utils.
3fae3e3
@brianhogg
Only update the file metadata if it exists, which seems to only be fo…
f5b71e5 
…r images.
@brianhogg
Adding select2 styling for the attachment page.
164e5dc
@brianhogg
Adding a warning about protecting media files with initial styling.
58d1b39
@brianhogg
Removing "unprotect" ability of just removing the filter meta. Once t…
9c921d1 
…he file is moved into the folder it's protected, would need to move the file out of the folder first.
@brianhogg
Formatting of the media protection option in the modal.
1ba2981
@brianhogg
WIP: Adding initial "protect" button for Images.
1dc18fd
@brianhogg
WIP: Need to register our rest API listener sooner.
29756f9
@brianhogg
Removing comment
d6d8414
@brianhogg
Updating link to Learn More about protection.
a677ed4
@brianhogg
Ignoring media protection block protect.
c554f96
@brianhogg
Moving the rest field registration earlier.
0e931e5
@brianhogg
Using the select2 dropdown in the protect modal.
cc86d59
@brianhogg
Formatting of the modal. Adding translatable strings.
8cee372
@brianhogg
WIP: Adding initial field. Need to initialize the select2 later.
ba179f9
@brianhogg
WIP: This works but only the first one when you click 'Replace' on an…
fa27007 
… existing image.
@brianhogg
This works, but needs to have the selected value (if any) and set the…
b3ca8ca 
… post type to course/membership.
brianhogg added 21 commits March 13, 2025 12:51
@brianhogg
Replace the file URL if it's changed, ie. when the file is first prot…
893b5a0 
…ected.
@brianhogg
Show existing selected option if any.
da29607
@brianhogg
Adding todo
4834223
@brianhogg
Changelog.
8c08c14
@brianhogg
Only serve file from our code if the auth filter meta exists, and onl…
33ee53e 
…y fetch an image if the size or icon param exists. Also check that it's an attachment post before serving it.
@brianhogg
Update version of e2e test utils.
e85bff8
@brianhogg
Only update the file metadata if it exists, which seems to only be fo…
4501c50 
…r images.
@brianhogg
Adding select2 styling for the attachment page.
627cc74
@brianhogg
Adding a warning about protecting media files with initial styling.
3fedbc3
@brianhogg
Removing "unprotect" ability of just removing the filter meta. Once t…
200499a 
…he file is moved into the folder it's protected, would need to move the file out of the folder first.
@brianhogg
Formatting of the media protection option in the modal.
5152d28
@brianhogg
WIP: Adding initial "protect" button for Images.
cca3155
@brianhogg
WIP: Need to register our rest API listener sooner.
4087fa3
@brianhogg
Removing comment
0019717
@brianhogg
Updating link to Learn More about protection.
8754c49
@brianhogg
Moving the rest field registration earlier.
3f202d6
@brianhogg
Using the select2 dropdown in the protect modal.
b810fcd
@brianhogg
Formatting of the modal. Adding translatable strings.
d8a8209
@brianhogg
Add support for video, audio and file. Only show the warning message …
2d4d9a8 
…if the file isn't already protected.
@brianhogg
Merge remote-tracking branch 'origin/additional-media-protection' int…
b86cc54 
…o additional-media-protection

# Conflicts:
#	src/js/admin-media-protection-block-protect.js
@brianhogg
Ensure user can at least edit courses before adding block editor prot…
0fbf1f4 
…ect icon.
@brianhogg brianhogg requested a review from ideadude as a code owner March 14, 2025 16:37
@ideadude ideadude moved this to Awaiting Review in Development Mar 14, 2025
@brianhogg brianhogg added this to the Next Available Release milestone Mar 31, 2025
@ideadude ideadude modified the milestones: Next Available Release, 8.1 Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Awaiting Review
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhogg @ideadude
0