Feature/account security #2677
Draft
Feature/account security #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhogg
reviewed
Apr 21, 2025
brianhogg
reviewed
Apr 21, 2025
includes/llms.spam.functions.php
Outdated
|
|
||
| // Remove old items. | ||
| $new_activity = []; | ||
| $now = current_time( 'timestamp', true ); // UTC |
There was a problem hiding this comment.
current_time( 'timestamp' ) isn't recommended since WP 5.3 https://make.wordpress.org/core/2019/09/23/date-time-improvements-wp-5-3/
includes/llms.spam.functions.php
Outdated
| $now = current_time( 'timestamp', true ); // UTC | ||
| foreach( $activity as $item ) { | ||
| // Determine whether this item is recent enough to include. | ||
| if ( $item > $now-( LLMS_SPAM_ACTION_TIME_LIMIT ) ) { |
There was a problem hiding this comment.
Wrap in absint() in case the constant is defined incorrectly
Comment on lines
+105
to
+108
| if ( count( $activity ) > LLMS_SPAM_ACTION_NUM_LIMIT ) { | ||
| rsort( $activity ); | ||
| $activity = array_slice( $activity, 0, LLMS_SPAM_ACTION_NUM_LIMIT ); | ||
| } |
There was a problem hiding this comment.
Add absint() around the constants
includes/llms.spam.functions.php
Outdated
|
|
||
| $ip = preg_replace( '/[^0-9a-fA-F:., ]/', '', $ip ); | ||
| $transient_key = 'llms_spam_activity_' . $ip; | ||
| $activity = get_transient( $transient_key ); |
There was a problem hiding this comment.
Not sure if it's an issue using transients when they can be deleted at any time? It does allow us to use the WP system of tracking the temporary data without making our own table etc.
…d key if preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are going to add some spam/security features:
[x] IP Block at checkout if there are more than 10 failures within 15 minutes.
[ ] Built in support for captcha's like recaptcha and turnstile.
[ ] Built in integration with Akismet to check emails at checkout/registration.
How has this been tested?
Screenshots
Types of changes
Checklist: