Fix issue #47 #60
Open
Fix issue #47 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
puellanivis
reviewed
Jan 17, 2025
Add full Version 2 compliance for parseItemLocationBox
puellanivis
reviewed
Jan 19, 2025
puellanivis
reviewed
Jan 19, 2025
There was a problem hiding this comment.
OK, I don’t see anything immediately objectionable. I think technically upgrading a uint16 field to uint32 could technically be a breaking change in some cases, but the fields should probably be expanded regardless, and it should be easy enough for people to cast or change casts where they show up. (That is: there’s no better way to do this, and the cost to users of the API is as minimal as it could be.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull addresses issue #47 and issue #48.
It adds a new test TestExiftool which uses an image that has it's metadata copied via exiftool, which uses a base offset of 4.
It corrects the parseItemLocationBox function to use the base offset size to read either 4 or 8 bytes as required based on the inbound base offset.