8000 fix: default logger have a bad init by 42atomys · Pull Request #48 · go-sprout/sprout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: default logger have a bad init #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: default logger have a bad init #48

merged 1 commit into from
Aug 16, 2024

Conversation

42atomys
Copy link
Member

Description

The default logger aren't initialized correctly causing crash when using the default logger without opts.

Changes

  • The default logger will now print on stdout

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

@42atomys 42atomys added type/bug 🔥 Something isn't working priority/critical 🟥 Priority 1 - Must be fixed ASAP domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously aspect/dex 🤖 Concerns developers' experience with the codebase state/done ✔ This is done! labels Aug 16, 2024
@42atomys 42atomys self-assigned this Aug 16, 2024
@codecov Codecov
Copy link
codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
sprout.go 100.0% <100.0%> (ø)

@42atomys 42atomys merged commit 0497869 into main Aug 16, 2024
14 checks passed
@42atomys 42atomys deleted the fix/default-logger-bad-init branch August 16, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@42atomys 42atomys

Labels
aspect/dex 🤖 Concerns developers' experience with the codebase domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously priority/critical 🟥 Priority 1 - Must be fixed ASAP state/done ✔ This is done! type/bug 🔥 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@42atomys
0