8000 update to errors that carry the value by casualjim · Pull Request #2313 · go-swagger/go-swagger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update to errors that carry the value #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020
Merged

update to errors that carry the value #2313

merged 1 commit into from
Jun 15, 2020

Conversation

casualjim
Copy link
Member

Signed-off-by: Ivan Porto Carrero ivan@flanders.co.nz

Signed-off-by: Ivan Porto Carrero <ivan@flanders.co.nz>
@codecov
Copy link
codecov bot commented Jun 13, 2020

Codecov Report

Merging #2313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2313   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files          50       50           
  Lines        8449     8449           
=======================================
  Hits         6870     6870           
  Misses       1082     1082           
  Partials      497      497           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548768a...b1ca570. Read the comment docs.

@casualjim casualjim merged commit 13907db into master Jun 15, 2020
@casualjim casualjim deleted the errors-with-value branch June 15, 2020 16:15
@v-antech
Copy link

This commit does not work with the latest errors dependency, as errors.Required() accepts 2 and not 3 arguments.

@casualjim
Copy link
Member Author
casualjim commented Jun 25, 2020

update your dependencies. The change is made across the board

https://github.com/go-openapi/errors/blob/07f65d36d3b56d4b56744489fe52f01425fe7028/schema.go#L488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0