Review of codegen imports and package name mangling #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #2181 +/- ##
==========================================
+ Coverage 81.13% 81.27% +0.13%
==========================================
Files 50 50
Lines 8326 8388 +62
==========================================
+ Hits 6755 6817 +62
- Misses 1074 1076 +2
+ Partials 497 495 -2
Continue to review full report at Codecov.
|
casualjim
approved these changes
Jan 26, 2020
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
* removed redundant code generation code regarding imports (and let goimport sort it out) * refactored imports in templates: imports are maps, codegen uses a language-specific funcmap * mangle tag-based package names to safe names and use package aliasing * introduced CLI option to disable tag-based package generation for operations * introduced CLI option to override main server package location * introduced x-go-operation-tag to alter tag-based package generation * made global tag definition honor the x-go-name tag to alter tag-based package generation * propagated changes to stratoscale contrib templates Issues fixes: * fixes go-swagger#1049 (tag override) * fixes go-swagger#2111 (tag mangling) * fixes go-swagger#2057 (tag mangling) * fixes go-swagger#1291 (tag mangling) * fixes go-swagger#1971 (main package mangling & main target override) TODO: name aliasing and mangling for imported models remains to be done Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Lean on previous preliminary refactoring work from PRs #2177 and #2173
removed redundant code generation code regarding imports (and let goimport sort it out)
refactored imports in templates: imports are maps, codegen uses a language-specific funcmap
mangle tag-based package names to safe names and use package aliasing
introduced CLI option to disable tag-based package generation for operations
introduced CLI option to override main server package location
introduced x-go-operation-tag to alter tag-based package generation
made global tag definition honor the x-go-name tag to alter tag-based package generation
propagated changes to stratoscale contrib templates
Issues fixes:
TODO: name aliasing and mangling for imported models remains to be done
Signed-off-by: Frederic BIDON fredbi@yahoo.com